Welcome to DU! The truly grassroots left-of-center political community where regular people, not algorithms, drive the discussions and set the standards. Join the community: Create a free account Support DU (and get rid of ads!): Become a Star Member Latest Breaking News Editorials & Other Articles General Discussion The DU Lounge All Forums Issue Forums Culture Forums Alliance Forums Region Forums Support Forums Help & Search

Renew Deal

(82,936 posts)
Thu Nov 17, 2022, 03:48 PM Nov 2022

Bug: Recommend button issues on mobile

This discussion thread was locked by EarlG (a host of the DU4 Bug Reports forum).

There is a problem with the recommend and other buttons on an iPhone.

If the phone is held the "normal" way, so the page is viewed from the top of the phone, the Rec button is missing. If the phone is rotated, the Rec button and number appear on top of the post text.

Also, when the phone is held the "normal" way, the "Info" button is indented, and trash is off the screen. Bookmark rolls to a new line.

This is all in Skinner mode. Let me know if you have questions. I can email screenshots if it helps.

12 replies = new reply since forum marked as read
Highlight: NoneDon't highlight anything 5 newestHighlight 5 most recent replies
Bug: Recommend button issues on mobile (Original Post) Renew Deal Nov 2022 OP
Screenshots would be very helpful EarlG Nov 2022 #1
I just sent screenshots Renew Deal Dec 2022 #2
Got them, thanks EarlG Dec 2022 #3
No problem. Thanks Renew Deal Dec 2022 #4
I think I got the Info/Bookmarks/Trash buttons taken care of EarlG Dec 2022 #5
I *think* these issues should be cleared up now EarlG Dec 2022 #6
Good news and bad news Renew Deal Dec 2022 #7
Hmm, okay EarlG Dec 2022 #8
I'm not seeing the sub-folders on mobile Lithos Dec 2022 #9
It seems to be an issue specifically related to this device type EarlG Dec 2022 #10
I have an iPhone 12 pro, not the IPhone 13 mini Lithos Dec 2022 #11
Hey, just saw the email EarlG Dec 2022 #12

EarlG

(22,550 posts)
1. Screenshots would be very helpful
Thu Nov 17, 2022, 04:37 PM
Nov 2022

Yes, please email them to me. Thanks.

Renew Deal

(82,936 posts)
2. I just sent screenshots
Tue Dec 13, 2022, 08:38 AM
Dec 2022

The issue still exists.

EarlG

(22,550 posts)
3. Got them, thanks
Tue Dec 13, 2022, 09:21 AM
Dec 2022

Sorry -- I realized I asked you to email these to me previously, then when you did today I asked you to post them in the forum. I got my wires crossed, my apologies.

Anyway -- I received the screenshots and see the issue -- working on it at the moment. Hopefully will have this sorted out soon.

Renew Deal

(82,936 posts)
4. No problem. Thanks
Tue Dec 13, 2022, 09:55 AM
Dec 2022

EarlG

(22,550 posts)
5. I think I got the Info/Bookmarks/Trash buttons taken care of
Tue Dec 13, 2022, 10:00 AM
Dec 2022

How do they look to you now?

Working on the Rec button next.

(FYI, there are still quite a lot of fixes to be done to Skinner mode since I've been mostly focused on default mode, so if you're using Skinner mode this is a good time for me to get feedback on what's still broken.)

EarlG

(22,550 posts)
6. I *think* these issues should be cleared up now
Tue Dec 13, 2022, 11:09 AM
Dec 2022

Info/Bookmarks/Trash buttons should be in the correct position on iPhone Mini.

Rec button should now be showing on Skinner Mode mobile.

Notes button should work correctly (when open, Rec button will push below Note area).

Landscape mode should look okay now.

Please let me know if any of that still looks busted, thanks.

Renew Deal

(82,936 posts)
7. Good news and bad news
Tue Dec 13, 2022, 04:32 PM
Dec 2022

The good news is Rec and Notes look good.

The bad new is that Info is now tucked under Bookmark. This is in both landscape and portrait. I can see a sliver of info and it opens if I touch the sliver. I don’t see trash at all.

Also, in Landscape, the top right corner of the post says Reply by Renew Deal. When that appears, the grey backgrounds combine and it pushes the date down a line.

I also notice when posting this reply that the preview and post buttons are not perfectly aligned. Post is slightly indented. Both buttons are as long as the screen. The indentation doesn’t exist in portrait.

Thanks for looking into this stuff.

EarlG

(22,550 posts)
8. Hmm, okay
Tue Dec 13, 2022, 06:05 PM
Dec 2022

I’ll have another look at this and see what I can do. I think I just need to shrink those buttons down just a little more.

Lithos

(26,462 posts)
9. I'm not seeing the sub-folders on mobile
Wed Dec 14, 2022, 11:58 AM
Dec 2022

Is this a known issue?

EarlG

(22,550 posts)
10. It seems to be an issue specifically related to this device type
Wed Dec 14, 2022, 02:17 PM
Dec 2022

It's an iPhone 13 mini held in landscape mode. For some reason Renew Deal is seeing the "tablet" CSS even though the device should be displaying the "mobile" CSS. My iPhone 12 is showing the mobile CSS in landscape orientation, and that's bigger than an iPhone 13 mini, so Renew Deal should see the mobile CSS too. It's a bit of a head-scratcher.

FWIW I'm working on fixes for this specifically in Default Mode. Renew Deal has had some layout issues in Skinner Mode and Night Mode as well, but those are separate issues -- I think those are to do with the fact that I didn't design quite small enough for a screen as small as an iPhone mini. Individual tweaks should take care of those.

Edited to add: I'm getting a bit mixed up about what thread I'm in, so to clarify, Renew Deal has two types of issue:

1) When he turns his phone to landscape orientation, he's getting the tablet CSS (which displays the left column, among other things) but he should be getting the mobile CSS (and I'm not sure why he isn't).

2) He's also having issues on various pages with buttons and other screen elements appearing out of place (variously, in Default Mode, Skinner Mode, and Night Mode). I believe that's because his screen size is smaller than the smallest size that I considered when creating these layouts, so some buttons are a bit too wide and push each other off the screen or into funky positions. Those I should be able to deal with on a case-by-case basis.

Lithos

(26,462 posts)
11. I have an iPhone 12 pro, not the IPhone 13 mini
Wed Dec 14, 2022, 09:15 PM
Dec 2022

Sent you an email of the screen shot.

Will try and load it up on my work phone which is an iPhone 11 in the next day or so.

Small suggestion - would it be better to have a generic testing email? ex: du4test@democraticunderground.com (?)

EarlG

(22,550 posts)
12. Hey, just saw the email
Wed Dec 14, 2022, 11:05 PM
Dec 2022

I wrote back cuz I wasn't sure about what you meant in the subject line about the sub folders, but aside from that, what you're seeing is correct -- you're getting the mobile layout when the phone is in landscape orientation. That's what is supposed to happen.

Renew Deal is somehow getting the tablet layout. It would make sense if he had a bigger phone than either of us -- it would just mean that I would likely need to bump up the width at which the media query tells the CSS to switch from tablet to mobile. But his phone is smaller than either of ours. If our phones are showing the mobile layout, his *definitely* should.

Latest Discussions»Help & Search»DU4 Bug Reports»Bug: Recommend button iss...